fix: add click as a direct dependency#822
Open
marcusburghardt wants to merge 1 commit intocomplytime:mainfrom
Open
fix: add click as a direct dependency#822marcusburghardt wants to merge 1 commit intocomplytime:mainfrom
marcusburghardt wants to merge 1 commit intocomplytime:mainfrom
Conversation
Contributor
Author
|
integration test is disabled by #821 |
marcusburghardt
force-pushed
the
fix/add-click-direct-dependency
branch
2 times, most recently
from
c3eafb0 to
28220ec
Compare
This was referenced Apr 21, 2026
marcusburghardt
force-pushed
the
fix/add-click-direct-dependency
branch
from
28220ec to
d479bf0
Compare
click is used as the CLI framework across 10 source files but was never declared as a direct dependency. It was implicitly resolved via compliance-trestle's transitive dependency on datamodel-code-generator. With compliance-trestle 3.11.0, datamodel-code-generator was removed from runtime dependencies, causing click to shift from the main poetry group to dev-only. This breaks the container image (which only installs main + plugins groups), resulting in ModuleNotFoundError at runtime and failing all e2e tests. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
fix/add-click-direct-dependency
branch
from
d479bf0 to
5a21579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickis used as the CLI framework across 10 source files incomplyscribe/cli/but was never declared as a direct dependency inpyproject.toml. It was implicitly resolved viacompliance-trestle's transitive dependency ondatamodel-code-generator.With
compliance-trestle3.11.0 (#778),datamodel-code-generatorwas removed from runtime dependencies (moved to[dev]extras), causingclickto shift from themainpoetry group todev-only inpoetry.lock. This breaks the container image built by theDockerfile(which only installsmain+pluginsgroups viapoetry install --with plugins --no-root), resulting inModuleNotFoundError: No module named 'click'at runtime and failing all 6 e2e tests.This PR adds
click = "^8.1.8"as a direct dependency and regeneratespoetry.lockso thatclickis back in themaingroup.Related Issues
Review Hints
pyproject.toml(one line added) andpoetry.lock(content-hash updated).poetry.lockdiff is minimal: only the content-hash and the Poetry version header changed.clickmoves fromgroups = ["dev"]back togroups = ["main", "dev", "plugins"].test-integrationfailures (complyctl list --plain/Error: unknown flag: --plain) are unrelated and already fail onmain. They will be addressed separately.