Open
Conversation
Off-screen spectrum gradient avoids bad sampling of black/grey indicator bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better mouse handling.
Some of the mouse interactions with the controls felt strange. I made a couple of changes to handle the mouse leaving/entering that made it feel more like traditional controls.
Off-screen spectrum gradient avoids bad sampling of black/grey indicator bar.
I was seeing an issue (at least in chrome) where when dragging downward, the color value would not be correct, typically being too gray. I believe this was related to when/where the color sample is taken and the indicator bar colors. Instead of doing that, I moved the spectrum gradient to an off-screen buffer from which the color values are read. This should also make a bit of a memory vs. cpu tradeoff in that the render() method does not need to recreate the gradient each call.