Merged
Conversation
|
LGTM! We just ran into this issue with our integrations https://circleci.com/gh/segment-integrations/analytics.js-integration-mixpanel/495 |
f2prateek
approved these changes
Sep 28, 2018
f2prateek
reviewed
Sep 28, 2018
| "debug": "2.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "mocha": "*" |
There was a problem hiding this comment.
Separately - we should pin this as well.
Collaborator
|
Thanks for the contribution @eastwood ! It's much appreciated. :) |
This was referenced Oct 1, 2018
|
bad solution |
Contributor
|
Would |
nfriedly
added a commit
to nfriedly/cookie-1
that referenced
this pull request
Oct 29, 2018
There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534 This was resolved in 2.6.9 and 3.1.0. Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that. In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0. Version `^2.6.9` could alternatively be used if desired. This Fixes component#16, Fixes component#15, and is is part of the fix for matthewmueller/next-cookies#7
Merged
nfriedly
added a commit
to nfriedly/cookie-1
that referenced
this pull request
Oct 29, 2018
There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534 This was resolved in 2.6.9 and 3.1.0. Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that. In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0. Version `^2.6.9` could alternatively be used if desired. This Fixes component#16, Fixes component#15, and is is part of the fix for matthewmueller/next-cookies#7
|
I think 2.6.9 would likely be safest. |
Contributor
|
Fair enough. PR with 2.6.9 (now) at #17 |
ucarion
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Require debug ^3.2.4 There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534 This was resolved in 2.6.9 and 3.1.0. Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that. In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0. Version `^2.6.9` could alternatively be used if desired. This Fixes #16, Fixes #15, and is is part of the fix for matthewmueller/next-cookies#7 * switch to ^2.6.9 based on feedback from @f2prateek
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to
debughas introduced some breaking changes in their new4.xbranch. For upstream consumers ofcomponent-cookie, these breaking changes have made their way into builds, especially those using older versions of node/npm etc.This PR addresses this issue and locks the debug version to
2.2.0similarly to thecomponent.jsonchange made in 91cb083