Merged
Conversation
added 2 commits
January 20, 2014 14:15
* component/bind for Function#bind * component/trim for String#trim * stephenmathieson/normalize to normalize the keydown event (to get which/target/preventDefault correct)
dominicbarnes
pushed a commit
to dominicbarnes/select
that referenced
this pull request
Jan 20, 2014
* component/bind for Function#bind * component/map for Array#map * component/indexof for Array#indexOf * component/query-zest for IE8 support of CSS selectors * dominicbarnes/pillbox@ie8_compat for IE8 compatibility (see component/pillbox#9) (and a development dependency change) * dominicbarnes/dom@ie8_compat for IE8 compatibility (no upstream PR yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting IE8 support with the help of some extra dependencies:
Function#bindString#trimkeydownevent gettarget,whichandpreventDefaultcorrectly