Closed
Conversation
Both Swipe.next and Swipe.prev take an optional `cycle` parameter. If `cycle` is truthy we rewind slides at the beginning and end. Swipe.cycle still works in the same way, but it's reimplemented as next(true)
Member
|
I'd personally like to avoid single boolean parameters. See: the boolean trap |
|
this seems like a global option, maybe |
Member
Author
|
Global option makes sense. Let me see if I can put together an alternative PR. |
Member
Author
|
See #22 for a better/different way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both Swipe.next and Swipe.prev take an optional
cycleparameter.If
cycleis truthy we rewind slides at the beginning and end.Swipe.cycle still works in the same way, but it's implemented as
next(true)Updated docs and one of the examples.