Skip to content

Conversation

@cristiandouce
Copy link
Member

component/events@1.0.5 solves a huge and horrible delegation bug introducing discore/closest to the matching logic.

As I explain at component/events#9, this update would help avoid a randomly (and difficult to sort) installation issue of that dependency.

@defunctzombie
Copy link
Contributor

I think we could just use the component/event module and not depend on events. The abstractions it provides we don't really need for the scope of this module. Anyone have thoughts on that?

@jonathanong
Copy link

yeah not a fan of component/events, but mostly because i use delegation for everything

@cristiandouce
Copy link
Member Author

So far this would really help me go through component/events#9, and have a nice sleep after months of torture. hahaha

About your question, I find component/events quite useful since there are at least 3 groups of event bindings:

  1. https://github.com/component/tip/blob/master/index.js#L62
  2. https://github.com/component/tip/blob/master/index.js#L63
  3. https://github.com/component/tip/blob/master/index.js#L102

I'd find that quite tricky using component/event API. Also it uses constructor methods as shown here https://github.com/component/tip/blob/master/index.js#L224; which is the value component/events adds over component/event.

@defunctzombie
Copy link
Contributor

I rewrote a local copy of tip I have to use event cause I didn't want to fix events dependencies over npm. It was not that bad and added maybe 2 lines of extra code.

@cristiandouce
Copy link
Member Author

Though, since tip uses events and events is broken (or at least, at an unstable pin)... I believe bumping that dep and providing with a component/tip@1.0.1 release as a mid term solution until we get to decide on a refactor deprecating events over event... is not a bad idea.

Right?

@cristiandouce
Copy link
Member Author

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants