Skip to content

Bp 834 drive popup #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamienola wants to merge 6 commits into from
Closed

Bp 834 drive popup #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92f9284
Bumping to 0.2.1
Jun 2, 2014
3357f54
bumped to 0.2.2
Jun 4, 2014
43b760c
bumped to 0.2.3
Jun 4, 2014
1b2fca4
bumped version to 0.2.4 and added a fix for iframe offsets
jamienola Aug 6, 2014
8b0b442
removed a comment
jamienola Aug 6, 2014
b24275f
added check for jquery objects
jamienola Aug 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions component.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "tip",
"description": "Tip component",
"version": "0.2.0",
"version": "0.2.4",
"keywords": [
"tooltip",
"tip",
Expand All @@ -10,7 +10,7 @@
"dependencies": {
"component/emitter": "*",
"component/inherit": "*",
"component/jquery": "*"
"virtru-components/jquery": "2.1.0"
},
"development": {
"component/aurora-tip": "*"
Expand Down
19 changes: 18 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,24 @@ Tip.prototype.offset = function(pos){
var ew = el.outerWidth();
var eh = el.outerHeight();

var to = target.offset();
// calculate the offset, taking iFrames into account
var to = {top: 0, left: 0};
var elem = target instanceof jQuery ? target[0] : target;
var doc = elem.ownerDocument;
var win = doc.defaultView || doc.parentWindow;

// iterate through DOM tree and store offset values for every iframe
do {
to.top += elem.offsetTop;
to.left += elem.offsetLeft;
elem = elem.offsetParent;

if(elem === null) {
elem = win.frameElement;
win = win.parent;
}
} while(elem);

var tw = target.outerWidth();
var th = target.outerHeight();

Expand Down
2 changes: 1 addition & 1 deletion template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="tip tip-hide">
<div class="tip-arrow"></div>
<div class="tip-inner"></div>
</div>
</div>