Conversation
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been looking for a way for scripts to have access to the relative path for a given asset file. Right now, using things like clipboard-dom require you to set a path manually, and that means needing to keep up the source changes with version changes.
This change adds support for replacing a specific pattern with the url that would also be used for CSS url-rewriting. For example:
The asset path is resolved relative to the file it is found in. Also, the asset does not have to be in the
component.json(at least we are not checking on that at this time)For plugin authors that require some sort of URL for finding an asset via AJAX, they will still need to expose some sort of hook for developers/users to set the URL specific. (since JS has no notion of relative URLs like CSS does) However, this should make the end-result far more robust. For example:
I've pushed a branch to clipboard-dom demonstrating this change. For non-component developers, nothing changes and this remains backwards compatible.