Local Dependencies Lookup Fail

[ignacioola]

My directory structure of components:

lib
 | - item
views
 | - list-view
 | - item-view

I have list-viewrequiring as a local dep item-view. And I have item-view requiring as a local dep from ../../lib the component item.

When I run component install over list-view, the lookup for item fails, because the path ../../lib is not added to the 'paths' on its component.json (even though running install under item-view works perfectly),

The error I get is:

error : failed to lookup "item-view"'s dep "item"

This path should be extracted from it's dependency item-view.

[cristiandouce]

I have the same issue!

[micky2be]

It's a big issue for me as well

[yields]

wonder what happens if you have a root component.json that lists both lib and views in .paths[].

[micky2be]

If you put all path needed in the root component.json it's working perfectly.
But it's not scalable for big project. It will require you to know all the dependencies of dependencies....

[cristiandouce]

Well, not the dependencies but at least their paths.
When listing item-view dependency path ../../lib within list-views paths, the lookup works perfect.

But I don't believe that this list-view component should ever have to be aware of its dependency dependencies paths. With just its direct dependencies paths should be enough.

[micky2be]

Exactly. This is a major issue that will need to be fix.
I'll see what I can do on my side and provide a fix if I can find something.

[ericgj]

I haven't built anything significant with component, so I probably should not comment, but wonder why you would need to design view components to depend on each other? I don't think of them like 'partial templates', but as semi-autonomous pieces of functionality that communicate with each other in a decoupled way.

So in the case of a list of items, I would start with a single component, maybe with several templates within it (one for the list and one for the item), but with all the logic for rendering them together in one component.

Whether you even need to depend on the item (model?) library is another question, if you look at the todo app example, you see that the model instance is injected into the view component, not required as a 'factory'. The thing is stitched together in top-level "boot" component rather than the views.

Anyway, maybe you have a different situation entirely but I found reading the todo app (and also the component.io website source) very enlightening.

[ignacioola]

it was just to illustrate the problem, you can put anything you want as the name of the components

[micky2be]

See #337 for a fix

[micky2be]

Kinda need a fix asap on this.
So, any feedback would be appreciated.

[ignacioola]

Sorry for the delay man.

Tried it and the problem was solved.

Thanks!

[cristiandouce]

I took my time to install @micky2be version and tried with an example working ok!
👍