Skip to content

Resolve Build Errors on Netlify#30

Merged
dannytlake merged 6 commits intomainfrom
fix/fix-pnpm-lock
Mar 2, 2024
Merged

Resolve Build Errors on Netlify#30
dannytlake merged 6 commits intomainfrom
fix/fix-pnpm-lock

Conversation

@dannytlake
Copy link
Copy Markdown
Contributor

@dannytlake dannytlake commented Mar 2, 2024

  • Composable UI uses pnpm as the package manager for the monorepo
  • In order to use pnpm and deploy to Netlify, we are required to hoist packages
  • A recently added package to our monorepo introduced package dependencies that when hoisted, was causing a build failure on Netlify (see screenshot below)
  • This PR consolidates versions of packages across the monorepo that were introducing build errors when packages are hoisted.

In order to mimic locally the behaviour of a Netlify build, you can set shamefully-hoist=true in the root .npmrc file.

image

Read more at:

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composable-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 2:38pm
composable-ui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 2:38pm

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 2, 2024

Deploy Preview for composable-ui-storefront canceled.

Name Link
🔨 Latest commit 51910a3
🔍 Latest deploy log https://app.netlify.com/sites/composable-ui-storefront/deploys/65e33976620886000851d9f1

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2024

Lines Statements Branches Functions
Coverage: 46%
45.08% (436/967) 19.08% (54/283) 19.58% (38/194)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant