Skip to content

Feat/conscia package sort #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannytlake merged 5 commits into from
Mar 25, 2024
Merged

Feat/conscia package sort #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9602067
Merge pull request #1 from composable-com/main
maria0r Mar 22, 2024
922bc5a
attempting conscia component sort
maria0r Mar 22, 2024
8bd8416
component sort
maria0r Mar 22, 2024
7b274fb
undoing conscia install changes
maria0r Mar 22, 2024
d6e3c17
updating image domain note
maria0r Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/conscia/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,18 @@ In order to use data from Conscia, the `cmsRouter` needs to use the `getPage` da
import { getPage } from '@composable/conscia'
```

:::note
Don't forget to update the `composable-ui/next.config.js` file with the image domains that you will be receiving. Please refer to the Next.JS documentation on `remotePatterns` [here](https://nextjs.org/docs/app/api-reference/components/image#remotepatterns). For example,

```json
images: {
remotePatterns: [
{
protocol: 'https',
hostname: '**.contentstack.io',
port: '',
},
],
}
```
:::
6 changes: 6 additions & 0 deletions packages/conscia/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,12 @@ export type ConsciaHeroBanner = {
description: string
url: string
}
sort_order?: number
}

export type ConsciaCTABanner = {
__typename: BannerFullProps['__typename']
sort_order?: number
containerMarginBottom?: number
containerMarginTop?: number
containerSize: BannerFullProps['containerSize']
Expand All @@ -67,6 +69,7 @@ export type ConsciaCTABanner = {

export type ConsciaFeatureCardsHeader = {
__typename: BannerTextOnlyProps['__typename']
sort_order?: number
centered: BannerTextOnlyProps['centered']
id: BannerTextOnlyProps['id']
content: BannerTextOnlyProps['content']
Expand All @@ -77,6 +80,7 @@ export type ConsciaFeatureCardsHeader = {

export interface ConsciaFeaturedProducts {
__typename: CommerceConnectorProps['__typename']
sort_order?: number
id: CommerceConnectorProps['id']
title: CommerceConnectorProps['title']
containerMarginBottom?: number
Expand All @@ -91,6 +95,7 @@ export interface ConsciaFeaturedProducts {

export type ConsciaGrid = {
__typename: GridProps['__typename']
sort_order?: number
id: GridProps['id']
columns: GridProps['columns']
containerMarginBottom?: number
Expand All @@ -102,6 +107,7 @@ export type ConsciaGrid = {

export type ConsciaTextCard = {
__typename: TextCardProps['__typename']
sort_order?: number
id: TextCardProps['id']
title: TextCardProps['title']
image: {
Expand Down
6 changes: 5 additions & 1 deletion packages/conscia/src/utils/page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ export const transformPage = ({
return {
__typename: 'pageSlug',
id: pageSlug,
items: Object.values(consciaPage.components).map(transformPageComponent),
items: Object.values(consciaPage.components)
.sort((a, b) => {
return (a.response.sort_order ?? 0) - (b.response.sort_order ?? 0)
})
.map(transformPageComponent),
metaDescription: '',
metaKeywords: [],
metaTitle: '',
Expand Down