oci: Switch to tar-core crate with sans-IO Parser#249
Merged
cgwalters merged 1 commit intocomposefs:mainfrom Mar 10, 2026
Merged
oci: Switch to tar-core crate with sans-IO Parser#249cgwalters merged 1 commit intocomposefs:mainfrom
cgwalters merged 1 commit intocomposefs:mainfrom
Conversation
Working on direct import from containers-storage: I hit on the fact that our tar parsing was very hand-rolled and incomplete. We didn't handle PAX overrides correctly, there was a big `todo!` for global headers where we'd panic, etc. Recently I did a new tar-core crate which is now part of the composefs org - it's "sans-io" so works cleanly with both sync and async parsing. Update the code to use it. The tar crate is retained as a dev-dependency for tar::Builder in tests. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Collaborator
Author
|
After looking at this one again I remembered that I'd seen widespread usage of Bytes in the async ecosystem, and indeed rebasing the logic using that is a lot cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #248