Closed
Conversation
regarding the documentation, it expects an integer. the previous implementation didn't work with node@20 anymore
|
Thank you! Can't wait until this ships so we can upgrade our CI. |
mcintyre94
added a commit
to solana-foundation/solana-web3.js
that referenced
this pull request
Oct 26, 2023
version-from-git is broken on Node20 fix we're waiting on: compulim/version-from-git#17
mcintyre94
added a commit
to solana-foundation/solana-web3.js
that referenced
this pull request
Oct 26, 2023
version-from-git is broken on Node20 fix we're waiting on: compulim/version-from-git#17
Merged
Owner
|
I am modernizing the CI/CD pipeline (move away from Travis) so we can publish properly. I am rolling your changes into my #17 and credited you in the CHANGELOG and comments. Thanks for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regarding the documentation, it expects an integer. the previous implementation didn't work with node@20 anymore
See: #16