Conversation
Contributor
robrobbins
commented
Jun 21, 2018
robrobbins
commented
- All of the contract dependencies are moved into the repo for us to edit (per audit)
- EIP20 removed in favor of O.Z ERC20
- Lint Fixes
- Compiler Fixes
rbharath
approved these changes
Jun 23, 2018
Contributor
rbharath
left a comment
rbharath
left a comment
There was a problem hiding this comment.
@robrobbins Awesome work getting all these changes through!
LGTM
| require(token.transferFrom(listing.owner, this, _amount)); | ||
|
|
||
| _Application(_listingHash, _amount, listing.applicationExpiry, _data, msg.sender); | ||
| emit _Application( |
Contributor
There was a problem hiding this comment.
Nice! Glad you swapped out for the emit statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.