Skip to content

Tried to modify key current of an object which has been already passed to a worklet#551

Merged
computerjazz merged 2 commits intocomputerjazz:mainfrom
elliottkember:elliott/tried-to-modify-key
Mar 26, 2025
Merged

Tried to modify key current of an object which has been already passed to a worklet#551
computerjazz merged 2 commits intocomputerjazz:mainfrom
elliottkember:elliott/tried-to-modify-key

Conversation

@elliottkember
Copy link
Copy Markdown
Contributor

@elliottkember elliottkember commented Sep 6, 2024 •
edited
Loading

I hit the error in #539 when using this library. The patch suggested in the issue has solved the problem for me.

Closes #539

@jzaefferer jzaefferer mentioned this pull request Sep 12, 2024
Closed
@eithe
Copy link
Copy Markdown

eithe commented Sep 18, 2024

Would be great to get this in at some point @computerjazz :) Confirmed to work in our app.

@BartoszGrajdek BartoszGrajdek mentioned this pull request Sep 23, 2024
Merged
48 tasks
@callaars
Copy link
Copy Markdown
Contributor

callaars commented Oct 17, 2024

@computerjazz please?

@davidjwriter
Copy link
Copy Markdown

davidjwriter commented Oct 29, 2024

I'm also running into this issue and it would be great to have the fix in soon :)

@ddrozdov
Copy link
Copy Markdown

ddrozdov commented Nov 29, 2024

@elliottkember would you please update the PR with the latest patch from #539 to resolve the warnings?

@kevinw0123
Copy link
Copy Markdown

kevinw0123 commented Dec 1, 2024 •
edited
Loading

@computerjazz please 🙏
Can we merge this?

@elliottkember
Copy link
Copy Markdown
Contributor Author

elliottkember commented Dec 2, 2024 •
edited
Loading

@ddrozdov Done – thank you for your help! Please double-check that it all looks good. And if you have further changes feel free to make a PR on my fork

@JustinRohweller JustinRohweller mentioned this pull request Jan 14, 2025
Open
@Kilian Kilian mentioned this pull request Jan 29, 2025
Open
@computerjazz computerjazz merged commit e38a361 into computerjazz:main Mar 26, 2025
thai99hanoi added a commit to thai99hanoi/react-native-draggable-flatlist that referenced this pull request Jul 3, 2025
@thai99hanoi
Revert "Tried to modify key current of an object which has been alrea…
0e04aab 
…dy passed to a worklet (computerjazz#551)"

This reverts commit e38a361.
molchanovskiy added a commit to molchanovskiy/react-native-draggable-flatlist that referenced this pull request Jul 24, 2025
@molchanovskiy
Squashed commit of the following:
55d1988 
commit 5a9291d
Author: Froredion <72370451+Froredion@users.noreply.github.com>
Date:   Sun Apr 27 10:01:19 2025 +0800

    final compatibility fix for SDK 52

commit 209b36a
Author: Froredion <72370451+Froredion@users.noreply.github.com>
Date:   Sun Apr 27 00:46:27 2025 +0800

    compatibility for SDK 52 v2

commit 215f53c
Author: Froredion <72370451+Froredion@users.noreply.github.com>
Date:   Sun Apr 27 00:36:48 2025 +0800

    compatibility for SDK 52

commit 2cf9a7e
Merge: 892db96 debd2ca
Author: Arpit Verma <111184979+arpitv96171@users.noreply.github.com>
Date:   Wed Apr 23 13:38:22 2025 +0100

    Merge branch 'main' into upgrade-reanimated-3xx

commit debd2ca
Author: Daniel Merrill <daniel.r.merrill@gmail.com>
Date:   Tue Apr 8 15:43:25 2025 -0700

    Update README.md

commit 6ccfab5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Apr 3 18:35:24 2025 -0700

    Bump @babel/helpers from 7.18.2 to 7.27.0 in /Example (computerjazz#582)

    Bumps [@babel/helpers](https://github.com/babel/babel/tree/HEAD/packages/babel-helpers) from 7.18.2 to 7.27.0.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-helpers)

    ---
    updated-dependencies:
    - dependency-name: "@babel/helpers"
      dependency-version: 7.27.0
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit d31aa63
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Apr 3 18:35:13 2025 -0700

    Bump nanoid from 3.3.4 to 3.3.11 in /Example (computerjazz#583)

    Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.4 to 3.3.11.
    - [Release notes](https://github.com/ai/nanoid/releases)
    - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
    - [Commits](ai/nanoid@3.3.4...3.3.11)

    ---
    updated-dependencies:
    - dependency-name: nanoid
      dependency-version: 3.3.11
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit d700c26
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Apr 3 18:35:02 2025 -0700

    Bump @babel/runtime from 7.21.0 to 7.27.0 in /Example (computerjazz#584)

    Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.21.0 to 7.27.0.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime)

    ---
    updated-dependencies:
    - dependency-name: "@babel/runtime"
      dependency-version: 7.27.0
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit d733391
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Apr 3 13:40:50 2025 -0700

    Bump body-parser from 1.20.2 to 1.20.3 in /Example (computerjazz#554)

    Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.20.2 to 1.20.3.
    - [Release notes](https://github.com/expressjs/body-parser/releases)
    - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
    - [Commits](expressjs/body-parser@1.20.2...1.20.3)

    ---
    updated-dependencies:
    - dependency-name: body-parser
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 763a7b6
Author: computerjazz <daniel.r.merrill@gmail.com>
Date:   Thu Apr 3 13:38:49 2025 -0700

    v4.0.2

commit e38a361
Author: Elliott Kember <elliott.kember@gmail.com>
Date:   Thu Mar 27 07:45:03 2025 +1300

    Tried to modify key current of an object which has been already passed to a worklet (computerjazz#551)

    * Apply patches from computerjazz#539

    * Incorporate changes from https://github.com/computerjazz/react-native-draggable-flatlist/issues/539\#issuecomment-2507728809

commit 892db96
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Thu Sep 5 13:48:18 2024 +0100

    [fix]: upgrading to expo 49

commit 63cc23a
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 23:12:49 2024 +0100

    [fix]: revert more not needed changes

commit 7b00c4c
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 23:11:30 2024 +0100

    [fix]: revert more not needed changes

commit 64d9d3f
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 23:11:07 2024 +0100

    [fix]: revert more not needed changes

commit 7bf05fc
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 23:09:46 2024 +0100

    [fix]: revert more not needed changes

commit cf5ccf0
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 23:05:53 2024 +0100

    [fix]: revert not required changes

commit 617ee7c
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 23:03:10 2024 +0100

    [fix]: revert example to expo 48

commit 3bc9de5
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 22:43:20 2024 +0100

    [fix]: remove unused code

commit 9939196
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 22:42:18 2024 +0100

    [fix]: remove experimental property

commit 8d2e44d
Author: Arpit Verma <arpitverma101967@gmail.com>
Date:   Wed Sep 4 22:31:15 2024 +0100

    [fix]: upgrade to reanimated 3.x.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jefferyjxn jefferyjxn jefferyjxn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tried to modify key current of an object which has been already passed to a worklet

8 participants

@elliottkember @eithe @callaars @davidjwriter @ddrozdov @kevinw0123 @jefferyjxn @computerjazz