Fix Monoid / SemiGroup instances for GHC 8.4#7
Merged
conal merged 1 commit intoconal:masterfrom Jul 16, 2018
Merged
Conversation
Build tested with GHC 8.0.2, 8.2.2 and 8.4.3.
Owner
|
Thanks. With GHC 8.0.2, I got some warnings for missing |
This was referenced Aug 20, 2018
Author
|
https://prime.haskell.org/wiki/Libraries/Proposals/SemigroupMonoid is saying So, apparently:
So as far as I know, if you want to keep support for GHC 8.0, you need Sorry I missed that in my PR. And I apologie I missed your comment and took one month to answer. |
Owner
|
Thanks very much for the explanations. I'm just catching up after a very distracted week. Released to Hackage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build tested with GHC 8.0.2, 8.2.2 and 8.4.3.