Basic Visual Studio examples updated to use Conan2#100
Open
tapia wants to merge 26 commits into
Open
Conversation
Member
|
For some reason CI is red: https://ci.conan.io/blue/organizations/jenkins/Examples/detail/PR-100/2/pipeline Could we check the CI pipelines? It would be great to have this green to start merging things |
memsharded
reviewed
Nov 25, 2021
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
It seems this example is missing the CI script. In the past we used to have one .bat and one .sh for CI in different platforms. I would be happy if we use just 1 .py for both, but as you prefer.
Please add the CI script, and lets get a green build to start merging.
memsharded
reviewed
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #99