This repository was archived by the owner on Mar 24, 2026. It is now read-only.
skip emsdk from kb-h016#348
Merged
Merged
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
4 tasks
jgsogo
previously approved these changes
Sep 30, 2021
SSE4
previously approved these changes
Oct 1, 2021
Contributor
|
@uilianries CI is not happy :( |
Contributor
|
Why this is not taking into account the changes from |
Member
Author
|
Good morning fellas, yes, it seems related to pylint version. |
Contributor
|
but this one (already merged) should have been fixed it: #349. The problem is that this PR is not using the requirements that are listed in the file 🤷 |
Member
Author
|
@jgsogo we should use |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Contributor
but if the file says |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
jgsogo
reviewed
Oct 1, 2021
Signed-off-by: Uilian Ries <uilianries@gmail.com>
jgsogo
approved these changes
Oct 1, 2021
Contributor
jgsogo
left a comment
jgsogo
left a comment
There was a problem hiding this comment.
Finally, it was just a lazy CI 😄
Member
Author
|
It's Friday, the CI wants a break! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to conan-io/conan-center-index#6163