[setup] Require python 3.6 as minimal version #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
xmo-odoo
added a commit
to xmo-odoo/python-patch-ng
that referenced
this pull request
Aug 9, 2024
Python 2 compatibility was removed in conan-io#31 so these should not be useful / necessary anymore.
uilianries
added a commit
that referenced
this pull request
Oct 1, 2025
* Remove Python 2 compatibility shims Python 2 compatibility was removed in #31 so these should not be useful / necessary anymore. * Remove dead `sys` import The CLI mode uses `sys` internally but has its own import. * Remove `to_file_bytes` It does almost nothing at this point and is only used by one caller, so can be inlined. * Minor fixes for Python 3 compat Signed-off-by: Uilian Ries <uilianr@jfrog.com> * Fix nested next method Signed-off-by: Uilian Ries <uilianr@jfrog.com> * Validate applying 30MB patch file Signed-off-by: Uilian Ries <uilianr@jfrog.com> * Update CI to fix hanging Linux build Signed-off-by: Uilian Ries <uilianr@jfrog.com> * Use specific patch version for python due python-setup rule Signed-off-by: Uilian Ries <uilianr@jfrog.com> * Use ubuntu 22.04 to have python 3.7 available Signed-off-by: Uilian Ries <uilianr@jfrog.com> --------- Signed-off-by: Uilian Ries <uilianr@jfrog.com> Co-authored-by: Uilian Ries <uilianr@jfrog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.x is EOL and Conan client requires Python 3.6 or higher.
This may break users, so maybe we could release a new major version?
Related to #20