Skip to content

Conversation

@sabjorn
Copy link

@sabjorn sabjorn commented Dec 21, 2017

added new flag, enable_tag_multibranch, to allow tag_filter option to use all branches of git repository. This is useful for when independent branches are used for release but tags are used for triggering builds.

@pivotal-issuemaster
Copy link

@sabjorn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@sabjorn Thank you for signing the Contributor License Agreement!

@vito
Copy link
Member

vito commented Dec 28, 2017

Hmm, I think the idea makes sense but I'm not sure this will work.

The --single-branch was added as an optimization, but the git log command that we run should still only apply to the configured branch.

Maybe branch should be optional if tag_filter is specified, and if left blank, tags should be queried across all branches, and --single-branch should not be used?

Also, could you add tests?

…riable without the presence of a branch variable will cause the git repo to be able to trigger from all tags (regardless of branch). Tests coming
@sabjorn
Copy link
Author

sabjorn commented Dec 28, 2017

@vito, closing this PR for now because the PR is on a branch which feeds into a CI build for the resource. I'll pop this back once I get these tests written.

@sabjorn sabjorn closed this Dec 28, 2017
@vito
Copy link
Member

vito commented Jan 11, 2018

for anyone following on, this is now tracked in #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants