Skip to content

Get only checking the first 100 assets in the release. #133

@kvmw

Description

@kvmw

Describe the bug

When listing the release assets to check them against the globs and download them, only the first 100 release assets are considered.
see the source code here.

Some releases like Bellsoft OpenJDK have more than 100 assets.

Reproduction steps

  1. add a github-release resource for OpenJDK 23
  - name: openjdk-release
    type: github-release
    source:
      owner: bell-sw
      repository: Liberica
      access_token: ((github.token))
      semver_constraint: "~23"
  1. add a glob in get step to download the JRE ( JRE is at the end of the list, not in the first 100 assets).
  - get: openjdk-release
    params:
      globs:
        - "bellsoft-jre*-linux-amd64.tar.gz"
  1. run the pipeline and check that no assets have been downloaded.

Expected behavior

the asset matching the provided glob should have been downloaded.

Additional context

Probably, the pagination should be considered for the listing of assets : https://github.com/google/go-github?tab=readme-ov-file#pagination

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions