Skip to content

Conversation

@ari-becker
Copy link

@ari-becker ari-becker commented Jun 5, 2020

Signed-off-by: Ari Becker <ari-becker@users.noreply.github.com>
Signed-off-by: Ari Becker <ari-becker@users.noreply.github.com>
@ari-becker ari-becker force-pushed the statically-configured-atc branch from dc9194d to 8d7b881 Compare June 5, 2020 16:44
# ... omitted for the sake of brevity ...
teams:
# ... omitted for the sake of brevity ...
projects:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may be better to nest .projects under .teams. What do you think @vito ?

Copy link

@clarafu clarafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I was actually already working on an approach towards starting concourse using a config file, the issue is here and I have an open draft PR here. I'd love to get your feedback on any of that if you would like!

increasing the costs for end teams. Reducing reliance upon the underlying
PostgreSQL database has a direct, positive effect on instance performance and
costs incurred by Concourse administrators.
* Perusing the current configuration for a Concourse instance, when so much of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what this point means, is this talking about the web configuration of the postgres instance (https://github.com/concourse/concourse/blob/master/atc/atccmd/command.go#L130) or the configuration of postgres itself (which is done depending how you deployed it through helm, bosh, etc).


## Replacing `fly set-team`

Doing so permits the configuration file to include additional configuration that
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an interesting idea, do you have a use case where an operator would like to restrict only being able to modify teams through the configuration file? My only concern with this is that it would require the operator to have to restart the web nodes everytime they want to make a change to the teams, but I do understand how it would be nice to have the true list of teams in the configuration file for the cluster. I guess I'm more curious of the "why" this would be nice for operators, to be able to be strict with the teams configuration?

reload this file, without restarting the process.

The contents of this configuration YAML file will permit listing any of the
existing options under `.options`. Sensitive strings may be substituted with
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the configuration fields needs to be under options:? In my proposal for starting concourse with a configuration file, I had it so that you can use one configuration file to start up your web and worker nodes. So the web configuration would be under web: and the worker configuration would be under worker:.

@clarafu clarafu removed their assignment May 16, 2022
@ari-becker
Copy link
Author

I'm cleaning up my old PRs, I left the position where I was using Concourse professionally.
I'd be happy to re-open if someone considers this to still be relevant.

@ari-becker ari-becker closed this Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants