-
Notifications
You must be signed in to change notification settings - Fork 37
RFC: Propose static configuration for Concourse instances #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ari Becker <ari-becker@users.noreply.github.com>
Signed-off-by: Ari Becker <ari-becker@users.noreply.github.com>
dc9194d to
8d7b881
Compare
| # ... omitted for the sake of brevity ... | ||
| teams: | ||
| # ... omitted for the sake of brevity ... | ||
| projects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be better to nest .projects under .teams. What do you think @vito ?
clarafu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| increasing the costs for end teams. Reducing reliance upon the underlying | ||
| PostgreSQL database has a direct, positive effect on instance performance and | ||
| costs incurred by Concourse administrators. | ||
| * Perusing the current configuration for a Concourse instance, when so much of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure what this point means, is this talking about the web configuration of the postgres instance (https://github.com/concourse/concourse/blob/master/atc/atccmd/command.go#L130) or the configuration of postgres itself (which is done depending how you deployed it through helm, bosh, etc).
|
|
||
| ## Replacing `fly set-team` | ||
|
|
||
| Doing so permits the configuration file to include additional configuration that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely an interesting idea, do you have a use case where an operator would like to restrict only being able to modify teams through the configuration file? My only concern with this is that it would require the operator to have to restart the web nodes everytime they want to make a change to the teams, but I do understand how it would be nice to have the true list of teams in the configuration file for the cluster. I guess I'm more curious of the "why" this would be nice for operators, to be able to be strict with the teams configuration?
| reload this file, without restarting the process. | ||
|
|
||
| The contents of this configuration YAML file will permit listing any of the | ||
| existing options under `.options`. Sensitive strings may be substituted with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the configuration fields needs to be under options:? In my proposal for starting concourse with a configuration file, I had it so that you can use one configuration file to start up your web and worker nodes. So the web configuration would be under web: and the worker configuration would be under worker:.
|
I'm cleaning up my old PRs, I left the position where I was using Concourse professionally. |
Rendered