cppcheck v2.16.2

[regro-cf-autotick-bot]

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

• Dependencies have been updated if changed: see upstream
• Tests have passed
• Updated license if changed and license_file is packaged

Information about this PR:

1. Feel free to push to the bot's branch to update this PR if needed.
2. The bot will almost always only open one PR per version.
3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #96

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12440633436 - please use this URL for debugging.}

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

[tovrstra]

This issue started with version 2.16.0. See #95 and #96 for other examples of failed builds.

@danmar Would you be able to comment on why the Windows build fails with the following error message, and how this could be fixed? (I have no practical experience with Windows.)

[201/211] Building CXX object cli\CMakeFiles\cli_objs.dir\cppcheckexecutorseh.cpp.obj
FAILED: cli/CMakeFiles/cli_objs.dir/cppcheckexecutorseh.cpp.obj 
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DFILESDIR=\"D:/bld/cppcheck_1734743165853/_h_env/share/Cppcheck\" -DWIN32 -DWIN32_LEAN_MEAN -D_CRT_SECURE_NO_WARNINGS -D_WIN64 -I%SRC_DIR%\build\cli -I%SRC_DIR%\cli -I%SRC_DIR%\lib -I%SRC_DIR%\externals\picojson -I%SRC_DIR%\externals\simplecpp -external:I%PREFIX%\Library\include -external:W0 /DWIN32 /D_WINDOWS /W3 /GR /EHsc /MD /O2 /Ob2 /DNDEBUG /W4 /Zi /MP /O2 /Ob2 /Oi /Ot /Oy /GF /MD /GS- /Gy /Zc:rvalueCast /wd4018 /wd4127 /wd4146 /wd4244 /wd4251 /wd4267 /wd4389 /wd4482 /wd4512 /wd4701 /wd4706 /wd4800 /wd4805 /Zc:throwingNew /Zc:__cplusplus /showIncludes /Focli\CMakeFiles\cli_objs.dir\cppcheckexecutorseh.cpp.obj /Fdcli\CMakeFiles\cli_objs.dir\ /FS -c %SRC_DIR%\cli\cppcheckexecutorseh.cpp
cl : Command line warning D9025 : overriding '/W3' with '/W4'
%SRC_DIR%\cli\cppcheckexecutorseh.cpp(263): error C2027: use of undefined type 'Settings'
%SRC_DIR%\cli\cppcheckexecutor.h(28): note: see declaration of 'Settings'
%SRC_DIR%\cli\cppcheckexecutorseh.cpp(263): error C2737: 'outputFile': const object must be initialized

@wolfv @thomashampson @seanyen @timsnyder Do you have an idea?

Can this be fixed by changing line 263 to the following?

[danmar]

@tovrstra hmm I am not sure. I can build with msvc 2022.. but I am not sure why. to me it looks like we need to add a #include "settings.h" somewhere in cppcheckexecutorseh.cpp
@firewave do you have feedback?

[danmar]

but I am not sure why.

I used the cmake build and in that there is:

cli/CMakeLists.txt:        target_precompile_headers(cli_objs PRIVATE precompiled.h)

And in the precompiled.h the settings.h is included.

which compiler do you use? can you clarify how you build?

[firewave]

The include is indeed missing in the file and that would be masked by using precompiled headers. I opened cppcheck-opensource/cppcheck#7152 to fix this in the branch.

So I guess no precompiled header are being used. I assume that is because some kind of compilation cache which is being utilized.

I do not think we need an additional job the CI for this. I am planning to integrate include-what-you-use for a Windows build which would cover this but I currently lack a native binary of that tool.