Skip to content

Conversation

@minrk
Copy link
Member

@minrk minrk commented Apr 2, 2022

while ipykernel technically pins setuptools 60 in setup.py, it doesn't actually need it and the pin causes installation issues

while ipykernel technically pins setuptools 60 in setup.py, it doesn't actually need it and the pin causes installation issues
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk minrk added the automerge Merge the PR when CI passes label Apr 2, 2022
@blink1073
Copy link
Member

Thank you!

@github-actions github-actions bot merged commit 99b343f into conda-forge:main Apr 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@minrk minrk deleted the unpin-setuptools branch April 2, 2022 11:16
@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 2, 2022 via email

@blink1073
Copy link
Member

I was planning to release a new ipykernel on Monday, should we do it now?

@blink1073
Copy link
Member

Or make a new build here with the pin restored?

@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 2, 2022 via email

@blink1073
Copy link
Member

Sounds good.

@minrk
Copy link
Member Author

minrk commented Apr 2, 2022

Sorry, I should have done the patch on setup.py as well, to remove the pin from pip.

this will break all downstream recipes with pip check.

I don't think that's true in general. pip check will only complain when some other package has pinned down setuptools, preventing the current version from being installed. The current version satisfies the pin, older versions work, so only pip check will complain, nothing will actually be broken. Only the subset of downstream packages that

  1. run pip check, and
  2. depend on both his package and another package that pins setuptools<60

should see any issue. The rest should not be affected.

Before this: envs couldn't be installed
After this: pip check may complain (only in those cases where envs couldn't be installed at all)

@minrk
Copy link
Member Author

minrk commented Apr 2, 2022

Forgot to mention: I think Monday's fine for 6.11.1. If this causes any downstream issues, I'll do the patch for setup.py here (that's better than restoring the pin, I think).

@bollwyvl
Copy link
Contributor

bollwyvl commented Apr 2, 2022

all downstream recipes with pip check.

totally right, not all. but certainly possible as..

  1. run pip check, and
  2. depend on both his package and another package that pins setuptools<60

yeah, i found one, hence making #121 in the first place! bad stuff afoot there, anyway, so just skipped pip check for now.

certainly i can offer no argument that runtime use of setuptools (or any of the build backends) is bad news, at any version, and look forward to the next bump... but its not breaking anything in particular at the moment.

@minrk minrk mentioned this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants