-
-
Notifications
You must be signed in to change notification settings - Fork 26
unpin setuptools #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin setuptools #122
Conversation
while ipykernel technically pins setuptools 60 in setup.py, it doesn't actually need it and the pin causes installation issues
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Thank you! |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
|
Without a patch of setup.py to remove the pin, this will break all
downstream recipes with pip check.
|
|
I was planning to release a new ipykernel on Monday, should we do it now? |
|
Or make a new build here with the pin restored? |
|
Yeah I dunno: it's been a rather confusing release at this point, and
different builds will be broken for various people in different ways.
At worst, folk have to pin, but if nobody but me is complaining, don't let
it take up more of your time.
|
|
Sounds good. |
|
Sorry, I should have done the patch on setup.py as well, to remove the pin from pip.
I don't think that's true in general.
should see any issue. The rest should not be affected. Before this: envs couldn't be installed |
|
Forgot to mention: I think Monday's fine for 6.11.1. If this causes any downstream issues, I'll do the patch for setup.py here (that's better than restoring the pin, I think). |
totally right, not all. but certainly possible as..
yeah, i found one, hence making #121 in the first place! bad stuff afoot there, anyway, so just skipped certainly i can offer no argument that runtime use of setuptools (or any of the build backends) is bad news, at any version, and look forward to the next bump... but its not breaking anything in particular at the moment. |
while ipykernel technically pins setuptools 60 in setup.py, it doesn't actually need it and the pin causes installation issues