Skip to content

Conversation

@rgommers
Copy link
Contributor

@rgommers rgommers commented Dec 2, 2022

The bot probably didn't trigger because the repo moved.

All patches can be dropped.

Closes gh-10

@rgommers rgommers requested a review from awvwgk as a code owner December 2, 2022 07:23
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@rgommers
Copy link
Contributor Author

rgommers commented Dec 2, 2022

One new test error, need to look into that:

______ ERROR at setup of test_pep518[sdist_to_wheel-purelib-and-platlib] _______

tmpdir_factory = TempdirFactory(_tmppath_factory=TempPathFactory(_given_basetemp=None, _trace=<pluggy._tracing.TagTracerSub object at 0x7ff6fde5f350>, _basetemp=PosixPath('/tmp/pytest-of-conda/pytest-0')))

    @pytest.fixture(scope='session')
    def pep518_wheelhouse(tmpdir_factory):
        wheelhouse = tmpdir_factory.mktemp('wheelhouse')
        meson_python = str(package_dir.parent.parent)
        # Populate wheelhouse with wheel for the following packages and
        # their dependencies.  Wheels are downloaded from PyPI or built
        # from the source distribution as needed.  Sources or wheels in
        # the pip cache are used when available.
        packages = [
            meson_python,
        ]
>       subprocess.run([sys.executable, '-m', 'pip', 'wheel', '--wheel-dir', str(wheelhouse), *packages], check=True)

...

E               subprocess.CalledProcessError: Command '['$PREFIX/bin/python3.11', '-m', 'pip', 'wheel', '--wheel-dir', '/tmp/pytest-of-conda/pytest-0/wheelhouse0', '$SRC_DIR']' returned non-zero exit status 1.

...

=========================== short test summary info ============================
ERROR tests/test_pep518.py::test_pep518[sdist_to_wheel-purelib-and-platlib] - subprocess.CalledProcessError: Command '['$PREFIX/bin/python3.11', '-m', 'pip', 'wheel', '--wheel-dir', '/tmp/pytest-of-conda/pytest-0/wheelhouse0', '$SRC_DIR']' returned non-zero exit status 1.
ERROR tests/test_pep518.py::test_pep518[wheel_directly-purelib-and-platlib] - subprocess.CalledProcessError: Command '['$PREFIX/bin/python3.11', '-m', 'pip', 'wheel', '--wheel-dir', '/tmp/pytest-of-conda/pytest-0/wheelhouse0', '$SRC_DIR']' returned non-zero exit status 1.
=================== 59 passed, 2 skipped, 2 errors in 30.17s ===================

@henryiii
Copy link

henryiii commented Dec 2, 2022

I predicted this in mesonbuild/meson-python#214 (comment) and the solution would have been to add -m "not isolated" to this recipe - but I was assured that "conda was already running in our CI" and this won't break, and told to "not add undiscoverable pytest magic". 🤷

Technically, this should be skipped - isolated builds are not supposed to be supported on conda, isolated builds are designed for a PyPI-only environment.

@awvwgk
Copy link
Member

awvwgk commented Dec 2, 2022

I predicted this in mesonbuild/meson-python#214 (comment) and the solution would have been to add -m "not isolated" to this recipe - but I was assured that "conda was already running in our CI" and this won't break, and told to "not add undiscoverable pytest magic".

Good point, it will probably come up from other packaging ecosystems sooner or later. Let's raise an issue upstream and patch the sdist accordingly here.

@awvwgk awvwgk merged commit 9d2b4d9 into conda-forge:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meson-python 0.11.0?

4 participants