Skip to content

Conversation

@jaimergp
Copy link
Member

@jaimergp jaimergp commented Dec 16, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Relevant refs upstream:

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 3 commits December 16, 2024 10:03
@jaimergp jaimergp changed the title Add C compiler Compile valgrind wrapper Dec 16, 2024
@jaimergp
Copy link
Member Author

jaimergp commented Dec 16, 2024

This is ready now @xhochy @kenodegard, thanks! Oops wait, this was noarch but the linter didn't bark at me when I added the compiler. "arching" it now.

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 16, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12350918146. Examine the logs at this URL for more detail.

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Dec 16, 2024

Is this only visible with an import test? Couldn't we also execute something what did break in your job directly?

@jaimergp
Copy link
Member Author

We'd need to create a pytest test file and run it. Not against it, but the import test looked simpler.

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@xhochy
Copy link
Member

xhochy commented Dec 16, 2024

We probably need something here like we do for aiohttp: Build a noarch package for all platforms, but also have an arch-specific one for linux.

@jaimergp
Copy link
Member Author

Upstream only publishes linux wheels now, though. I'm not even sure this works outside Linux environments.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and see whether someone requests osx support.

@xhochy xhochy merged commit 3dab028 into conda-forge:main Dec 16, 2024
7 checks passed
@art049
Copy link

art049 commented Dec 17, 2024

Hey just discovered this repo.

As you mentionned, we just switched to prebuilt wheels in pytest-codspeed [v3.1.0]9https://github.com/CodSpeedHQ/pytest-codspeed/releases/tag/v3.1.0).

Upstream only publishes linux wheels now, though. I'm not even sure this works outside Linux environments.

It works outside linux environment however the instrumentation capabilities are not enabled.

@minrk minrk mentioned this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants