Skip to content

ENH: Add Linux ppc64le builds#1

Merged
matthewfeickert merged 11 commits into
conda-forge:mainfrom
matthewfeickert:feat/add-linux-builds
Nov 14, 2024
Merged

ENH: Add Linux ppc64le builds#1
matthewfeickert merged 11 commits into
conda-forge:mainfrom
matthewfeickert:feat/add-linux-builds

Conversation

@matthewfeickert
Copy link
Copy Markdown
Member

@matthewfeickert matthewfeickert commented Nov 14, 2024

  • Enable builds for platforms linux_ppc64le.
  • Add patch to set CMAKE_CXX_FLAGS from environment CXXFLAGS.
  • Bump build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

* Enable builds for platforms: linux_aarch64, linux_ppc64le.
* Bump build number.
@matthewfeickert matthewfeickert self-assigned this Nov 14, 2024
@matthewfeickert
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert
Copy link
Copy Markdown
Member Author

matthewfeickert commented Nov 14, 2024

For aarch64

cc1plus: error: unknown value 'nocona' for '-march'
cc1plus: note: valid arguments are: armv8-a armv8.1-a armv8.2-a armv8.3-a armv8.4-a armv8.5-a armv8.6-a armv8.7-a armv8.8-a armv8-r armv9-a armv9.1-a armv9.2-a armv9.3-a
cc1plus: error: unknown value 'haswell' for '-mtune'
cc1plus: note: valid arguments are: cortex-a34 cortex-a35 cortex-a53 cortex-a57 cortex-a72 cortex-a73 thunderx thunderxt88p1 thunderxt88 octeontx octeontx81 octeontx83 thunderxt81 thunderxt83 ampere1 ampere1a emag xgene1 falkor qdf24xx exynos-m1 phecda thunderx2t99p1 vulcan thunderx2t99 cortex-a55 cortex-a75 cortex-a76 cortex-a76ae cortex-a77 cortex-a78 cortex-a78ae cortex-a78c cortex-a65 cortex-a65ae cortex-x1 cortex-x1c neoverse-n1 ares neoverse-e1 octeontx2 octeontx2t98 octeontx2t96 octeontx2t93 octeontx2f95 octeontx2f95n octeontx2f95mm a64fx tsv110 thunderx3t110 neoverse-v1 zeus neoverse-512tvb saphira cortex-a57.cortex-a53 cortex-a72.cortex-a53 cortex-a73.cortex-a35 cortex-a73.cortex-a53 cortex-a75.cortex-a55 cortex-a76.cortex-a55 cortex-r82 cortex-a510 cortex-a710 cortex-a715 cortex-x2 cortex-x3 neoverse-n2 cobalt-100 neoverse-v2 demeter generic
cc1plus: error: unknown value 'nocona' for '-march'
cc1plus: note: valid arguments are: armv8-a armv8.1-a armv8.2-a armv8.3-a armv8.4-a armv8.5-a armv8.6-a armv8.7-a armv8.8-a armv8-r armv9-a armv9.1-a armv9.2-a armv9.3-a
cc1plus: error: unknown value 'haswell' for '-mtune'
cc1plus: note: valid arguments are: cortex-a34 cortex-a35 cortex-a53 cortex-a57 cortex-a72 cortex-a73 thunderx thunderxt88p1 thunderxt88 octeontx octeontx81 octeontx83 thunderxt81 thunderxt83 ampere1 ampere1a emag xgene1 falkor qdf24xx exynos-m1 phecda thunderx2t99p1 vulcan thunderx2t99 cortex-a55 cortex-a75 cortex-a76 cortex-a76ae cortex-a77 cortex-a78 cortex-a78ae cortex-a78c cortex-a65 cortex-a65ae cortex-x1 cortex-x1c neoverse-n1 ares neoverse-e1 octeontx2 octeontx2t98 octeontx2t96 octeontx2t93 octeontx2f95 octeontx2f95n octeontx2f95mm a64fx tsv110 thunderx3t110 neoverse-v1 zeus neoverse-512tvb saphira cortex-a57.cortex-a53 cortex-a72.cortex-a53 cortex-a73.cortex-a35 cortex-a73.cortex-a53 cortex-a75.cortex-a55 cortex-a76.cortex-a55 cortex-r82 cortex-a510 cortex-a710 cortex-a715 cortex-x2 cortex-x3 neoverse-n2 cobalt-100 neoverse-v2 demeter generic
Assembler messages:
Error: unknown architecture `nocona'

The line

set(CMAKE_CXX_FLAGS "-Wall -Wextra -march=nocona -mtune=haswell -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -fext-numeric-literals")

includes -march=nocona, which isn't necessarily supported, so will need to patch this to remove -march=nocona on non-x86 builds, or maybe patch it out to remove it fully.

Related Issues

@matthewfeickert matthewfeickert marked this pull request as draft November 14, 2024 09:19
@matthewfeickert matthewfeickert force-pushed the feat/add-linux-builds branch 2 times, most recently from 6823aa7 to badca88 Compare November 14, 2024 19:35
@matthewfeickert
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert changed the title ENH: Add Linux aarch64 and ppc64le builds ENH: Add Linux ppc64le builds Nov 14, 2024
@matthewfeickert
Copy link
Copy Markdown
Member Author

matthewfeickert commented Nov 14, 2024

Given conda-forge/ctng-compilers-feedstock#160 it doesn't seem possible to build on any aarch64 platforms for the time being if quadmath is required, like it is here.

conda-forge-webservices[bot] and others added 2 commits November 14, 2024 21:22
@matthewfeickert
Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11846264685.

@matthewfeickert matthewfeickert marked this pull request as ready for review November 14, 2024 22:07
@matthewfeickert matthewfeickert merged commit 335db57 into conda-forge:main Nov 14, 2024
@matthewfeickert matthewfeickert deleted the feat/add-linux-builds branch November 14, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants