Feature: Adding sqlite persistence applying migrations to sqlite #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2025 03:47
orkes-venkat
changed the title
orkes-venkat
force-pushed
the
sqlite_persistence
branch
from
d8037ea to
8e77db8
Compare
codehackerr
reviewed
Feb 12, 2025
| while (null != causeException && !(causeException instanceof SQLException)) { | ||
| causeException = causeException.getCause(); | ||
| } | ||
| return (SQLException) causeException; |
Contributor
There was a problem hiding this comment.
Have we verified, it will always be an SQLException ?
codehackerr
reviewed
Feb 12, 2025
| super(retryTemplate, objectMapper, dataSource); | ||
| this.scheduledExecutorService = | ||
| Executors.newSingleThreadScheduledExecutor( | ||
| ExecutorsUtil.newNamedThreadFactory("postgres-execution-")); |
codehackerr
reviewed
Feb 12, 2025
| super(retryTemplate, objectMapper, dataSource); | ||
| this.properties = properties; | ||
| this.executorService = null; | ||
| // this.properties = properties; |
Contributor
There was a problem hiding this comment.
Mercilessly remove unused code :) . You can get it from version history if it is ever relevant.
codehackerr
reviewed
Feb 12, 2025
| DataSource dataSource, | ||
| SqliteProperties properties) { | ||
| super(retryTemplate, objectMapper, dataSource); | ||
| // //this.pollDataFlushInterval = properties.getPollDataFlushInterval().toMillis(); |
Contributor
There was a problem hiding this comment.
Remove if not required
codehackerr
reviewed
Feb 12, 2025
| TimeUnit.MILLISECONDS); | ||
| logger.debug("{} is ready to serve", SqliteBaseDAO.class.getName()); | ||
|
|
||
| // if (properties.getExperimentalQueueNotify()) { |
Contributor
There was a problem hiding this comment.
Remove if not required
codehackerr
reviewed
Feb 12, 2025
| @@ -0,0 +1,37 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
This may have nothing specific to sqlite. This is potentially more of a common util ?
codehackerr
reviewed
Feb 12, 2025
| import java.util.function.Supplier; | ||
|
|
||
| /** Functional class to support the lazy execution of a String result. */ | ||
| public class LazyToString { |
codehackerr
reviewed
Feb 12, 2025
| * @author mustafa | ||
| */ | ||
| @FunctionalInterface | ||
| public interface QueryFunction<R> { |
Contributor
There was a problem hiding this comment.
DB, but not sqlite specific ? package and module
orkes-venkat
force-pushed
the
sqlite_persistence
branch
from
883c38e to
547e682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Adding Sqlite based implementation in the conductor repo, in this PR i have added migration steps to migrate the tables to sqlite
Alternatives considered
Describe alternative implementation you have considered