Skip to content

Conversation

@Pugazhenthi-Elangovan
Copy link

@Pugazhenthi-Elangovan Pugazhenthi-Elangovan commented Apr 6, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

  • Add param lockAcquired in terminateWorkflow to avoid 2nd lock to be held in same thread

(Issue)[issues/295]
Conductor Properties:

conductor.app.workflowExecutionLockEnabled=true
conductor.app.workflowOffsetTimeout=3600
  • Workflow status update delayed by 60 seconds due to dual locks when task is failed with lock enabled
    When the same thread tries to lock the same workflow in subsequent operations (decide and termination), workflow termination is delayed by lockLeaseTime. Thread is hanging there until lockLeaseTime is completed.

Alternatives considered

Describe alternative implementation you have considered

Copy link
Contributor

@VerstraeteBert VerstraeteBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR below has provides a more holistic solution to locking inconsistencies.
#496

@pugazhenthi-elangovan-E3338

Thanks @VerstraeteBert. Let me close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants