Skip to content

Conversation

@ruben-mathews
Copy link
Contributor

@ruben-mathews ruben-mathews commented Jul 11, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed
Issue # #551

  • Current the spaces for json keys are not causing validation exception when creating/updating the workflow def.
  • Since we are using json path to resolve the paths, we are compiling and checking if the paths is right one.

Alternatives considered

Describe alternative implementation you have considered

  • There is an alternative to remove the whitespace check. however this may start allowing users to provide invalid paths

@ruben-mathews ruben-mathews changed the title Allow Json Keys with spaces in the placeholders [Bug Fix] Allow Json Keys with spaces in the placeholders Jul 11, 2025
@ssesha
Copy link
Contributor

ssesha commented Jul 21, 2025

@v1r3n can help with this?

@ssesha
Copy link
Contributor

ssesha commented Jul 28, 2025

Can help with this review? @jeffbulltech @v1r3n

@Sreevani871
Copy link

any update on this @v1r3n ?

@ruben-mathews
Copy link
Contributor Author

@v1r3n Could help in merging this pr?

@v1r3n v1r3n merged commit cbf53e8 into conductor-oss:main Aug 22, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants