fixes docker-compose build by disabling Spotless check #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
v1r3n
approved these changes
Oct 8, 2025
Contributor
Author
|
OK, so the CI builds are failing due to testing and HTTP client mismatches relating to PR #69. I'm merging this simple docker fix in for now, since it solves an urgent issue, and making a new issue describing the test failures and what to do about them. (I would have just fixed them in this PR but their nature indicates they might require some decisionmaking.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.(Yes, ironically, this was also done -- fixing some code that was breaking the build due to some bad formatting that snuck in somehow.)
Changes in this PR
Issue #587
This fix makes the docker compose NOT dependent on whether spotlessApply has been perfectly applied and allows it to compile regardless.
Talked to @v1r3n about different possible solutions -- the other main one to consider would have been a docker build that tries to build with spotless enabled, and then runs spotlessApply if it doesn't. This would make a build take a strangely long time out of the blue, and probably wouldn't help us notice the formatting issue.
We should of course be running spotlessApply before each commit, and to that end, I'm putting in a suggested pre-commit hook (see the README and file in hooks/) that can be optionally added by a developer working on the project.