Skip to content

Update mapping#106

Merged
fcarrero merged 37 commits intomainfrom
update-mapping
Mar 2, 2026
Merged

Update mapping#106
fcarrero merged 37 commits intomainfrom
update-mapping

Conversation

@fcarrero
Copy link
Collaborator

@fcarrero fcarrero commented Mar 2, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the OpenAPI specification by updating the generator tool version and refining various API schemas. The changes aim to improve consistency in naming conventions, correct schema references, and add more precise data type definitions for fields related to payment methods, charges, and payout orders. These updates contribute to a more robust and clearly defined API contract.

Highlights

  • OpenAPI Generator CLI Update: The version of the OpenAPI Generator CLI used in the Dockerfile and Makefile has been updated from 7.18.0 to 7.20.0.
  • Schema Title Standardization: Numerous schema files have had their title properties standardized to follow a consistent snake_case naming convention, often by appending _request or _response or removing generic prefixes like 'a '.
  • Payment Method Schema Refinements: Changes were made to various payment method schemas, including correcting references for spei_recurrent to spei_recurrent_response, adding title and x-discriminator-value properties, and introducing a propertyName: object field for better discrimination.
  • Payout Order Enhancements: The payout_order and payout_order_response schemas were updated to include expires_at and status as required fields, and the amount field now explicitly specifies format: int64.
  • Charge Response and Order Schema Improvements: The charge_response schema now allows paid_at to be nullable, and charges_order_response and order_response schemas now correctly reference pagination/page.yml.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Dockerfile
    • Updated the openapi-generator-cli version from 7.18.0 to 7.20.0.
  • Makefile
    • Updated the openapitools/openapi-generator-cli Docker image version from v7.18.0 to v7.20.0.
  • resources/customers/create_customer_payment_methods.yml
    • Updated references for spei_recurrent to spei_recurrent_response.
  • resources/customers/update_customer_payment_methods.yml
    • Updated references for spei_recurrent to spei_recurrent_response.
  • resources/subscriptions/subscriptions_cancel.yml
    • Removed the x-methods extension from the subscription response schema.
  • schemas/antifraud/risk_rules_list.yml
    • Added a title property to the main schema and to the items within the data array.
  • schemas/api_keys/api_key_request.yml
    • Renamed the title and name properties from api_keys_request to api_key_request.
  • schemas/charges/charge_order_response.yml
    • Renamed the title from charges_data_response to charge_order_response.
    • Added propertyName: object to the payment_method property.
    • Renamed pbb_payment to pay_by_bank_payment in the discriminator mapping.
  • schemas/charges/charge_payment_method_bank_transfer_response.yml
    • Added title: payment_method_bank_transfer and x-discriminator-value: bank_transfer_payment.
  • schemas/charges/charge_payment_method_bnpl_payment_response.yml
    • Added title: payment_method_bnpl_payment.
    • Added an object property with an enum bnpl_payment.
  • schemas/charges/charge_payment_method_card_response.yml
    • Added title: payment_method_card.
  • schemas/charges/charge_payment_method_cash_response.yml
    • Added title: payment_method_cash and x-discriminator-value: cash.
  • schemas/charges/charge_payment_method_pbb_payment_response.yml
    • Added title: payment_method_pbb_payment.
  • schemas/charges/charge_request.yml
    • Renamed the title from charges to charge_request.
  • schemas/charges/charge_response.yml
    • Renamed the title from charges_data_response to charge_response.
    • Updated the paid_at property type to allow null values.
    • Added propertyName: object to the payment_method property.
  • schemas/charges/charges_order_response.yml
    • Added title: charges_order_response.
    • Included a reference to ../pagination/page.yml.
    • Simplified the items reference for data.
  • schemas/checkouts/checkout.yml
    • Renamed the title from checkout_request to checkout.
  • schemas/companies/company_response.yml
    • Added title: company_document_response to the items within the documents array.
  • schemas/customers/customer.yml
    • Renamed the title from customer request to customer.
  • schemas/customers/customer_payment_method_card_response.yml
    • Added title: payment_method_card_response.
  • schemas/customers/customer_payment_method_cash_response.yml
    • Added x-discriminator-value: cash and title: payment_method_cash_response.
    • Added title: cash_agreements_response to the items within the agreements array.
    • Removed a trailing newline character.
  • schemas/customers/customer_payment_method_spei_recurrent_response.yml
    • Renamed the schema definition from payment_method_spei_recurrent to payment_method_spei_recurrent_response.
    • Added title: payment_method_spei_recurrent_response and x-discriminator-value: spei_recurrent.
  • schemas/customers/customer_response.yml
    • Updated references for spei_recurrent to spei_recurrent_response.
    • Updated the subscription reference path and added title: customer_subscription_response.
  • schemas/customers/customer_shipping_contacts_response.yml
    • Added title: customer_shipping_contacts_response to the main schema.
    • Added title: customer_shipping_contacts_address to the address property.
    • Standardized indentation for street2 and city properties.
  • schemas/customers/update_customer.yml
    • Renamed the title from update customer request to update_customer.
  • schemas/events/events_resend_response.yml
    • Renamed the title from event_webhook_resend_response to events_resend_response.
  • schemas/logs/log_response.yml
    • Renamed the title from log response for request to log_response_for_request.
  • schemas/logs/logs_response.yml
    • Renamed the title from log response for request to logs_response_for_request.
  • schemas/orders/discount_lines_response.yml
    • Renamed the title from discount_lines_order_response to discount_lines_response.
  • schemas/orders/fiscal_entity_address.yml
    • Renamed the title from order_fiscal_entity_address_request to fiscal_entity_address.
  • schemas/orders/order_request.yml
    • Renamed the title from a order to order_request.
  • schemas/orders/order_response.yml
    • Included a reference to ../pagination/page.yml within order_charges_response.
  • schemas/orders/split_order_request.yml
    • Renamed the title from a order to split_order_request.
  • schemas/pagination/page.yml
    • Removed a trailing newline character.
  • schemas/payout_orders/payout_order.yml
    • Renamed the title from payout order request to payout_order_request.
    • Added expires_at as a required field and a new property.
    • Added format: int64 to the amount property.
  • schemas/payout_orders/payout_order_response.yml
    • Added expires_at and status as required fields.
    • Added format: int64 to the amount property.
  • schemas/plans/plan_request.yml
    • Renamed the title from a plan to plan_request.
  • schemas/tokens/token_response.yml
    • Renamed the title from token response to token_response.
  • schemas/webhooks/webhook_request.yml
    • Renamed the title from a webhook to webhook_request.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/check.yml
    • .github/workflows/rdme-openapi.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant number of updates and refactorings to the OpenAPI specification files. The changes include upgrading the openapi-generator-cli version, renaming schemas for better consistency, adding titles to inline schemas, and fixing schema references. While most of these changes improve the specification's quality and consistency, I've found a few issues related to missing discriminator values in polymorphic schemas. These omissions could lead to incorrect code generation for clients. Please see the detailed comments for suggestions on how to fix them.

@fcarrero fcarrero merged commit 435bafa into main Mar 2, 2026
7 checks passed
@fcarrero fcarrero deleted the update-mapping branch March 2, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant