Set VersionPrefix/Suffix if normal Version/AssemblyVersion not found #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conficient
approved these changes
Apr 19, 2019
Owner
|
Thanks for the clarification and the pull request. |
conficient
added a commit
that referenced
this pull request
Apr 19, 2019
Owner
|
Spotted a typo in line 46 which I've fixed: I'm also going to remove the exception if no versions are found and use the default that appears in projects as 1.0.0. Version v1.15 should now be live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the script to return early if the
<Version>or<AssemblyVersion>property values are found as<VersionPrefix>/<VersionSuffix>are not used in that scenario.Only if
<Version>,<AssemblyVerison>and<VersionPrefix>are missing does the task throw an error.I also edited this in vscode which did some auto-formatting with the Powershell extension installed (hence the open braces on the same line as the function/expression).
This is to solve #4