Update versions to support Spring Boot#12
Closed
ryan-barker-zefr wants to merge 2 commits intoconfluentinc:4.0.xfrom
Closed
Update versions to support Spring Boot#12ryan-barker-zefr wants to merge 2 commits intoconfluentinc:4.0.xfrom
ryan-barker-zefr wants to merge 2 commits intoconfluentinc:4.0.xfrom
Conversation
Author
Contributor
Ewen Cheslack-Postava (ewencp)
left a comment
There was a problem hiding this comment.
As commented on related PRs, this wouldn't make sense for this branch as we still support running with JDK 7 and these version names wouldn't work with how we do release versioning and how these values get updated in the release process.
Author
|
As mentioned elsewhere, this change was required during to the parent poms
not being in the same repo as the child. Typically you would get around
this with maven submodules. The version numbers are a fairly standard for
temporary fork releases.
The change for rest utils was the only actual change. Java 7 support seems
questionable to me at this point but that is your call. Staying in old
jetty versions will open you to security holes that will never be patched.
Java 7 itself has old versions of TLS that are not supported as well.
Up to you what you want to do here. the code and unit test changes to
support the latest versions are the only real work done.
…On Mon, May 7, 2018, 1:56 PM Ewen Cheslack-Postava ***@***.***> wrote:
***@***.**** commented on this pull request.
As commented on related PRs, this wouldn't make sense for this branch as
we still support running with JDK 7 and these version names wouldn't work
with how we do release versioning and how these values get updated in the
release process.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWcfiwUlWrgSMAxakL-eW4dCIY7OzXeNks5twLTfgaJpZM4Tv8Da>
.
|
Contributor
|
+1 to Ewen Cheslack-Postava (@ewencp)'s point -- this breaks expectations about versions for us; we can't accept this PR. Closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See confluentinc/common#117