This repository was archived by the owner on Apr 12, 2025. It is now read-only.
Generate RSA key pair (instead of DSA)#1
Merged
Ewen Cheslack-Postava (ewencp) merged 1 commit intoJun 14, 2016
Conversation
The same change was done in the Kafka docs: apache/kafka#1416
Contributor
|
Ismael Juma (@ijuma) does the same parameter need to be used when creating the trust store, too? Apart from that, LGTM. |
Member
Author
|
We only need it when generating keys, ie |
Contributor
|
LGTM. Thanks Ismael Juma (@ijuma)! |
Member
Author
|
Alex L (@alexlod), I don't seem to have write access to this repository so I can't merge the PR. |
Contributor
|
Ismael Juma (@ijuma) Sorry about that, added this to our normal team so everyone should have write access now. |
Member
Author
|
Thanks Ewen! |
Contributor
|
Thanks Ewen Cheslack-Postava (@ewencp) and Ismael Juma (@ijuma)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same change was done in the Kafka docs: apache/kafka#1416
Review by Alex L (@alexlod).