CC-7524: Bump Datagen connector version in cp-quickstart#361
CC-7524: Bump Datagen connector version in cp-quickstart#361Chris Egerton (C0urante) wants to merge 1 commit intoconfluentinc:5.3.xfrom C0urante:cc-7254
Conversation
|
Yeva Byzek (@ybyzek) @sdanduConf could one/both of you take a look at this? |
|
Verified locally on CP 5.3.1, 5.3.2-SNAPSHOT, and 5.4.0-SNAPSHOT (using the quickstart on the 5.4.x branch). |
Srini Dandu (sdandu-gh)
left a comment
There was a problem hiding this comment.
LGTM, thanks!
|
Yeva Byzek (@ybyzek) would you mind taking a look? Don't have merge permission on this repo. |
|
Chris Egerton (@C0urante) I made this change in Do you think it is necessary to have it backported in |
|
As long as the LOE is as low as just merging this PR, I'd say it's probably best that we do backport to 5.3.x. In fact, it may even be worth it to backport to 5.3.0-post (or further) so that all the quickstarts use the same version of the connector, but that's your call. |
|
If this change is going to be made to earlier branches, the changes:
So I propose we don't backport (and close this PR) given that:
|
Jira
The most recent release of the Datagen connector, 0.1.7, includes a fix that removes the
AvroConverterclass from its dependencies. This prevents that class from being picked up as a converter plugin by the Connect framework, which as of apache/kafka#7315 is guaranteed to happen on up-to-date versions of the framework. The Datagen connector excludes several transitive dependencies of the Avro converter, so any the version that's packaged with the connector is used as a converter plugin, things break.