Skip to content

CC-7524: Bump Datagen connector version in cp-quickstart#361

Closed
Chris Egerton (C0urante) wants to merge 1 commit intoconfluentinc:5.3.xfrom
C0urante:cc-7254
Closed

CC-7524: Bump Datagen connector version in cp-quickstart#361
Chris Egerton (C0urante) wants to merge 1 commit intoconfluentinc:5.3.xfrom
C0urante:cc-7254

Conversation

@C0urante
Copy link
Copy Markdown

Jira

The most recent release of the Datagen connector, 0.1.7, includes a fix that removes the AvroConverter class from its dependencies. This prevents that class from being picked up as a converter plugin by the Connect framework, which as of apache/kafka#7315 is guaranteed to happen on up-to-date versions of the framework. The Datagen connector excludes several transitive dependencies of the Avro converter, so any the version that's packaged with the connector is used as a converter plugin, things break.

@C0urante
Copy link
Copy Markdown
Author

Yeva Byzek (@ybyzek) @sdanduConf could one/both of you take a look at this?

@C0urante
Copy link
Copy Markdown
Author

Verified locally on CP 5.3.1, 5.3.2-SNAPSHOT, and 5.4.0-SNAPSHOT (using the quickstart on the 5.4.x branch).

Copy link
Copy Markdown
Contributor

@sdandu-gh Srini Dandu (sdandu-gh) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@C0urante
Copy link
Copy Markdown
Author

Yeva Byzek (@ybyzek) would you mind taking a look? Don't have merge permission on this repo.

@ybyzek
Copy link
Copy Markdown
Contributor

Chris Egerton (@C0urante) I made this change in 5.4.x branch via #363.

Do you think it is necessary to have it backported in 5.3.x?

@C0urante
Copy link
Copy Markdown
Author

As long as the LOE is as low as just merging this PR, I'd say it's probably best that we do backport to 5.3.x. In fact, it may even be worth it to backport to 5.3.0-post (or further) so that all the quickstarts use the same version of the connector, but that's your call.

@ybyzek
Copy link
Copy Markdown
Contributor

Yeva Byzek (ybyzek) commented Dec 3, 2019

If this change is going to be made to earlier branches, the changes:

  1. Must be validated on each of those branches (which you did for cp-quickstart)
  2. Should be applied to all instances where it is used, for which there are six demos:
ccloud/beginner-cloud/Dockerfile:RUN confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.1.6
ccloud/start.sh:confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.1.6
cp-quickstart/start.sh:confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.1.6
security/rbac/scripts/enable-rbac-connect.sh:echo "confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.1.6"
security/rbac/scripts/enable-rbac-connect.sh:confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.1.6
security/acls/Dockerfile:RUN confluent-hub install --no-prompt confluentinc/kafka-connect-datagen:0.1.6

So I propose we don't backport (and close this PR) given that:

  1. This explodes the matrix of testing
  2. I already updated to 0.1.7 to all demos in DEVX-1308: update all datagen connector versions from 0.1.6 to 0.1.7 #363
  3. 5.4.1-post will soon be the default branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants