fixes #409: Adds support for compacted topics and commit offset resetting#425
Merged
Antony Stubbs (astubbs) merged 35 commits intoconfluentinc:masterfrom Oct 12, 2022
Conversation
Track expected offsets returned from broker, and truncate where needed.
Contributor
Author
Antony Stubbs (astubbs)
left a comment
Antony Stubbs (astubbs)
left a comment
There was a problem hiding this comment.
....
Contributor
Author
|
This needs some more careful thinking through, the solution proposed won't work. I thought it needed to be checked continuously, but actually it may indeed only be upon first initial poll - as it's only the committed offset that's affected, not the offset map - I think. |
This reverts commit 23c289f
Antony Stubbs (astubbs)
changed the title
Contributor
Author
done. |
…ion-reset-latest # Conflicts: # CHANGELOG.adoc # README.adoc # parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/offsets/BitSetEncoder.java
Antony Stubbs (astubbs)
changed the title
Antony Stubbs (astubbs)
changed the title
Antony Stubbs (astubbs)
changed the title
Contributor
Author
Antony Stubbs (astubbs)
left a comment
Antony Stubbs (astubbs)
left a comment
There was a problem hiding this comment.
...
Antony Stubbs (astubbs)
changed the title
Contributor
Author
Antony Stubbs (astubbs)
left a comment
Antony Stubbs (astubbs)
left a comment
There was a problem hiding this comment.
lgtm
Antony Stubbs (astubbs)
deleted the
fixes/state-truncation-reset-latest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Truncate the offset state when bootstrap polled offset higher or lower than committed
** Prune missing records from the tracked incomplete offset state, when they're missing from polled batches
Fixes:
Checklist