CIAM-261: Add Jetty ThreadPool Metrics#205
CIAM-261: Add Jetty ThreadPool Metrics#205Manikumar Reddy (omkreddy) merged 2 commits intoconfluentinc:masterfrom
Conversation
| MetricName busyThreadCountMetricName = metrics.metricName(busyThreadCountName, | ||
| metricGroupName, " jetty thread pool active thread count.", | ||
| tags); | ||
| Gauge<Integer> busyThreadCount = (config, now) -> getBusyThreads(); |
There was a problem hiding this comment.
Jetty QueuedThreadPool provides #getBusyThreads
Manikumar Reddy (omkreddy)
force-pushed
the
threadpool
branch
5 times, most recently
from
8b73b5a to
95f72ae
Compare
Manikumar Reddy (omkreddy)
force-pushed
the
threadpool
branch
from
95f72ae to
5c2320e
Compare
|
|
||
| private void addJettyThreadPoolMetrics(Metrics metrics, Map<String, String> tags) { | ||
| //add metric for jetty thread pool queue size | ||
| String requestQueueSizeName = "thread-pool-queue-size"; |
There was a problem hiding this comment.
In DbRequestMetrics.java, we have request-queue-size, active-task-count, and thread-pool-usage. Why are these names different? Why don't we have a usage metric? (getBusyThreads() / getThreads()?)
There was a problem hiding this comment.
Updated thread-pool-queue-size => request-queue-size and add thread-pool-usage metric..
I have not changed busy-thread-count metric name as its meaning different from active-task-count in jetty thread pool implementation.
Aneel Nazareth (WanderingStar)
left a comment
Aneel Nazareth (WanderingStar)
left a comment
There was a problem hiding this comment.
I think we should be consistent about metric names for similar things.
Manikumar Reddy (omkreddy)
force-pushed
the
threadpool
branch
from
b80ed91 to
3bd5383
Compare
Aneel Nazareth (WanderingStar)
left a comment
Aneel Nazareth (WanderingStar)
left a comment
There was a problem hiding this comment.
Thanks for the updates. Looks good.
2 participants
No description provided.