MINOR: Fix compilation error from createKeyStore#207
Merged
Matthew Wong (mattwong949) merged 1 commit intoconfluentinc:masterfrom Oct 13, 2020
mattwong949:test-keystore-fix
Merged
MINOR: Fix compilation error from createKeyStore#207Matthew Wong (mattwong949) merged 1 commit intoconfluentinc:masterfrom mattwong949:test-keystore-fix
Matthew Wong (mattwong949) merged 1 commit intoconfluentinc:masterfrom
mattwong949:test-keystore-fix
Conversation
Matthew Wong (mattwong949)
requested review from
Andrew Egelhofer (andrewegel) and
Bob Barrett (bob-barrett)
|
It looks like Matthew Wong (@mattwong949) hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
Bob Barrett (bob-barrett)
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
confluentinc/kafka@7be8bd8#diff-10d99f28c40b6cd9640f95b1c763a7b2b4daaa0209249e1a724698f28a90df9bL118-L126 Removed the function definition of
createKeyStorethat tests in this repo were using. This PR fixes the compilation errors by conforming to the remaining definition ofcreateKeyStorethat required two Password args.I was able to compile and run the tests locally