Add some basic request metrics#6
Merged
Ewen Cheslack-Postava (ewencp) merged 5 commits intomasterfrom Jan 29, 2015
Merged
Conversation
Contributor
Author
|
Neha Narkhede (@nehanarkhede) Thoughts on this? Ideally we can get a good set to cover most of what both kafka-rest and schema-registry need. |
Contributor
Author
|
Blocked on confluentinc/common#11 |
…d only report metrics if they have the annotation.
…rics for request and response size.
Contributor
Author
|
Neha Narkhede (@nehanarkhede) Ready for you to look at this again. confluentinc/kafka-rest#23 shows how it gets used. There are a couple of changes required because I had to rework some rest-utils classes (we'll also have to make them in schema-registry), but the major change to users of rest-utils is just annotating the resource methods with better names. |
Conflicts: core/src/main/java/io/confluent/rest/RestConfig.java
Contributor
Author
|
Merging based on review of confluentinc/kafka-rest#23. |
Ewen Cheslack-Postava (ewencp)
added a commit
that referenced
this pull request
Jan 29, 2015
Add some basic request metrics
mapr-devops (mapr-devops)
pushed a commit
to mapr/rest-utils
that referenced
this pull request
Aug 23, 2025
…confluentinc#6) Co-authored-by: Prince Raheja <114437476+rahejaprince@users.noreply.github.com> Co-authored-by: ConfluentSemaphore <40306929+ConfluentSemaphore@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some basic metrics that work for any rest-utils application. The two commits add metrics at different levels. The first adds some basic TCP connection-level stats by hooking into Jetty, and the second adds HTTP level stats by hooking into Jersey.
It's probably easiest to see what there is by looking at the JMX stats for the example application. A few important questions for review:
request-rate.TopicResource.produceso that all requests could be aggregated intorequest-rate, but that seemed wrong when I also wanted multiple metrics grouped underTopicResource.produce. The current patch just has extra sensors that are always used for the global stats.