Add hook to allow applications to configure the JSON ObjectMapper.#7
Merged
Ewen Cheslack-Postava (ewencp) merged 1 commit intomasterfrom Jan 29, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Ewen Cheslack-Postava (@ewencp) What is the purpose of the wrapping?
Contributor
Author
There was a problem hiding this comment.
Not strictly necessary, I just tend to prefer dependency injection at construction to mutators. We could just as easily change this to a call to setMapper() in Application.
Contributor
There was a problem hiding this comment.
Makes sense.
Contributor
|
LGTM |
Ewen Cheslack-Postava (ewencp)
added a commit
that referenced
this pull request
Jan 29, 2015
Add hook to allow applications to configure the JSON ObjectMapper.
Ewen Cheslack-Postava (ewencp)
deleted the
configurable-json-object-mapper
branch
airlock-confluentinc bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Prince Raheja <114437476+rahejaprince@users.noreply.github.com> Co-authored-by: ConfluentSemaphore <40306929+ConfluentSemaphore@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows toggling ObjectMapper feature flags. I'm running into an issue now with features in Jackson that aren't permitted by default because they aren't always safe to combine. This hook lets me work around the issue.