-
Notifications
You must be signed in to change notification settings - Fork 43
feat(vsa): migrate to single in-toto 0.0.2 entry storage #2933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
/retest |
- Replace dual in-toto 0.0.1 + DSSE 0.0.1 entries with single in-toto 0.0.2 - Return `ssldsse.Envelope` directly from retrieval instead of JSON - Remove `VSAWithSignatures` and dual-entry pairing logic - Eliminate redundant DSSE reconstruction in hot path - Update signature verification to use `ssldsse.Envelope` directly - Leverage in-toto 0.0.2 native DSSE envelope support This migration simplifies VSA storage and retrieval by consolidating to one entry per VSA. Signature verification and payload inspection remain supported via the DSSE envelope embedded in the entry. Assisted by: claude-4-sonnet
dheerajodha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall logic lgtm, added a few comments related to the cleanup.
|
FTR: I tested the changes from this PR by uploading a new VSA for an image and then fetching the content from Rekor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except the failing tests)
ssldsse.Envelopedirectly from retrieval instead of JSONVSAWithSignaturesand dual-entry pairing logicssldsse.EnvelopedirectlyThis migration simplifies VSA storage and retrieval by consolidating to one entry per VSA. Signature verification and payload inspection remain supported via the DSSE envelope embedded in the entry.
Assisted by: claude-4-sonnet