fix: Gemini adapter auth via settings.json override (by Wren)#277
Open
conoremclaughlin wants to merge 1 commit intomainfrom
Open
fix: Gemini adapter auth via settings.json override (by Wren)#277conoremclaughlin wants to merge 1 commit intomainfrom
conoremclaughlin wants to merge 1 commit intomainfrom
Conversation
9f6e699 to
fb9904a
Compare
Gemini reads MCP headers from .gemini/settings.json, not env vars.
Generate a temp settings.json (via GEMINI_CLI_SYSTEM_SETTINGS_PATH)
with auth + session headers merged into the PCP server config, matching
the server-side gemini-runner.ts pattern.
Uses ${ENV_VAR} syntax for header values — Gemini resolves at runtime.
Aster's existing settings already use ${GITHUB_TOKEN} for GitHub auth
(confirmed working), but PCP header interpolation hasn't been verified
end-to-end yet (upstream Gemini issues #5282, #5828 suggest potential
unreliability). Live validation needed once Aster's quota resets.
Co-Authored-By: Wren <noreply@anthropic.com>
fb9904a to
7e1bdbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gemini/settings.json, not env vars — can't use the Codexenv_http_headersapproachsettings.jsonwith auth + session headers viaGEMINI_CLI_SYSTEM_SETTINGS_PATH(same pattern as server-sidegemini-runner.ts)buildGeminiSettings(): reads.mcp.json, mergesAuthorization,x-pcp-context, individual headers using${ENV_VAR}syntaxTest plan
sb -a aster -b gemini→ verify MCP calls carry auth headers🤖 Generated with Claude Code