This repository was archived by the owner on Dec 10, 2021. It is now read-only.
Conversation
Deadarius
force-pushed
the
add-file-ref-support
branch
from
e1095f2 to
9544c11
Compare
lwcooper
approved these changes
May 7, 2019
lwcooper
left a comment
lwcooper
left a comment
There was a problem hiding this comment.
Lack of tests is a bit worrying in this whole module really! But not gonna block this PR being merged
| @@ -1,10 +1,11 @@ | |||
| import { JSONSchema7 } from 'json-schema'; | |||
| import _ = require('lodash'); | |||
There was a problem hiding this comment.
this syntax looks weird. how does it work? I've never seen it before
also, we normally use ramda 🙈 But I can see how much it makes sense to just replace the existing utils with lodash here 👍
Author
There was a problem hiding this comment.
This is an open source project, I would prefer to keep it easy for people to contribute - lodash is more aligned with this idea than ramda
| * @param options | ||
| */ | ||
| constructor (serverless, options) { | ||
| constructor (serverless: IFullServerless, options) { |
Author
There was a problem hiding this comment.
This project is not configured(yet?) to use strict typescript transpilation.
Author
|
RE: test covereage - #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json-schema-ref-parserto combine bundle schemas while preserving $refsLint errors to be fixed