fix: tracing deserialization #1163
Conversation
Signed-off-by: Sander Pick <sanderpick@gmail.com>
| #[serde_as] | ||
| #[derive(Debug, Deserialize, Clone, Default, strum::EnumString, strum::Display)] | ||
| #[strum(serialize_all = "snake_case")] | ||
| #[serde(rename_all = "lowercase")] |
There was a problem hiding this comment.
apparently #[strum(serialize_all = "snake_case")] only applies to and from string, not with serde.
| .with_list_parse_key("eth.tracing.file.domain_filter") | ||
| .with_list_parse_key("eth.tracing.file.events_filter"), |
There was a problem hiding this comment.
Are these necessary for the Eth API process? I think it should just reuse the general tracing configuration, and if we want to enable/disable Eth API tracing, we should have an Eth domain we can disable through the domain_filter.
There was a problem hiding this comment.
Nice, that sounds better. So maybe EthSettings should just have a subset of the tracing settings? as in:
pub domain_filter: Option<Vec<String>>,
pub events_filter: Option<Vec<String>>,
There was a problem hiding this comment.
I'm happy to make that change if sounds right... would prefer to do in a diff PR.
Signed-off-by: Sander Pick <sanderpick@gmail.com>
| max_log_files = 5 # Number of files to keep after rotation | ||
| rotation = "daily" # Options: minutely, hourly, daily, never | ||
| ## Optional: filter events by domain | ||
| domain_filter = "Bottomup, Consenesus, Mpool, Execution, Topdown, TracingError" |
There was a problem hiding this comment.
looking for instances of impl_traceables!, I didn't find one with "TracingError", but there was one with "System"
Co-authored-by: raulk <raul.kripalani@gmail.com>
3 participants
domain_filterandevents_filtervia env