Skip to content

Check PHPDoc and typehints declaration #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VasekPurchart merged 1 commit into from
Jun 20, 2018
Merged

Check PHPDoc and typehints declaration #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Consistence/Sniffs/Exceptions/ExceptionDeclarationSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public function register(): array
}

/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
*
* @param \PHP_CodeSniffer\Files\File $phpcsFile
* @param int $classPointer
*/
Expand Down
4 changes: 4 additions & 0 deletions Consistence/Sniffs/NamingConventions/ValidVariableNameSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ class ValidVariableNameSniff extends \PHP_CodeSniffer\Sniffs\AbstractVariableSni
];

/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
*
* @param \PHP_CodeSniffer\Files\File $file
* @param int $stackPointer position of the double quoted string
*/
Expand All @@ -51,6 +53,7 @@ protected function processVariable(PhpCsFile $file, $stackPointer): void
}

/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
* @codeCoverageIgnore
*
* @param \PHP_CodeSniffer\Files\File $file
Expand All @@ -62,6 +65,7 @@ protected function processMemberVar(PhpCsFile $file, $stackPointer): void
}

/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
* @codeCoverageIgnore
*
* @param \PHP_CodeSniffer\Files\File $file
Expand Down
8 changes: 8 additions & 0 deletions Consistence/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@
<rule ref="SlevomatCodingStandard.TypeHints.LongTypeHints"/>
<rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/>
<rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/>
<rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration">
<properties>
<property name="allAnnotationsAreUseful" value="true"/>
<property name="traversableTypeHints" type="array">
<element value="Traversable"/>
</property>
</properties>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing"/>
<rule ref="SlevomatCodingStandard.Types.EmptyLinesAroundTypeBraces"/>
<rule ref="Squiz.Arrays.ArrayBracketSpacing">
Expand Down
5 changes: 5 additions & 0 deletions build/cs-ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,9 @@
"/>
</properties>
</rule>
<rule ref="SlevomatCodingStandard.TypeHints.TypeHintDeclaration">
<properties>
<property name="enableObjectTypeHint" value="false"/><!-- requires 7.2+ -->
</properties>
</rule>
</ruleset>