Skip to content

Enable reloading of views even if state / URL has not changed #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lee-borsboom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable reloading of views even if state / URL has not changed #21

lee-borsboom wants to merge 1 commit into from

Conversation

@lee-borsboom
Copy link
Contributor

@lee-borsboom lee-borsboom commented Sep 8, 2017

No description provided.

@lee-borsboom
Copy link
Contributor Author

lee-borsboom commented Sep 8, 2017 •
edited
Loading

Infinite loop fixed... was caused because the list pages call Route.go when they load - they were relying on the fact that the router didn't reload when nothing had changed, but in this PR I'd defaulted Route.go to force a reload. Default is now forceReload = false.

I think force reloading is a more intuitive default and could be combined with some route-href/route-on-click updates to fix the issue we have where clicking the main navigation links doesn't reload the view. Before we can do that we need to update (at least) our list pages though, so I'll defer that for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylezeeuwen kylezeeuwen Awaiting requested review from kylezeeuwen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lee-borsboom