QBXML Objects: asQBXML parameter conflict between parent and child classes.#260
Open
mreiden wants to merge 4 commits intoconsolibyte:masterfrom
Open
QBXML Objects: asQBXML parameter conflict between parent and child classes.#260mreiden wants to merge 4 commits intoconsolibyte:masterfrom
mreiden wants to merge 4 commits intoconsolibyte:masterfrom
Conversation
…ent method (Many also have conflicting parameter declarations and some use undefined constants like QUICKBOOKS_XML_XML_DROP). Remove the _cleanup method if it only calls the parent method.
This was referenced Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony 4.2+ complains the parameters of the asQBXML method of child classes do not match those in the QuickBooks_QBXML_Object parent class. This will throw an error starting in Symfony 5.
Prevent this and simplify the child classes by removing the methods if they do nothing other than call the parent method.
This pull request is based on top of #258.