Open
Conversation
fix all curly braces plucking strings, fixes consolibyte#1 Closes consolibyte#1 See merge request iservice/QuickBooks!1
Contributor
|
@ServiceTo , most of this stuff was already fixed. Please rebase to keep only missing parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php 7.4 and php 8 have removed the ability to use curly braces to select a single character from a string.
Error is: Array and string offset access syntax with curly braces is deprecated at ....
The fix is to use square brackets. https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
Searched for \w{ with regex and replaced all instances manually, there's two instances that aren't applicable.
My commit includes a lot of whitespace changes due to my IDE settings so easier to review by adding ?w=1 to the URL to hide the whitespace changes.