Support PHP 8.1 + other improvements#314
Open
GregPeden wants to merge 13 commits intoconsolibyte:masterfrom
Open
Support PHP 8.1 + other improvements#314GregPeden wants to merge 13 commits intoconsolibyte:masterfrom
GregPeden wants to merge 13 commits intoconsolibyte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes accommodate PHP 8.1.
I did also change the SQL sort in order to make explicit prioritization work more like how most would expect it to work.
And I added an "error threshold" setting to better comply with SOAP error code definitions whereby an error code below 500 is considered non-blocking and execution should proceed.
Sorry for bundling this all in, these are just changes accumulated for my own project over the past few months which I am proposing to share back to the project. Up to you! :)